Skip to content

Conversation

@resyntax-ci
Copy link
Contributor

@resyntax-ci resyntax-ci bot commented Feb 9, 2025

Resyntax fixed 20 issues in 10 files.

  • Fixed 11 occurrences of let-to-define
  • Fixed 3 occurrences of make-temporary-directory-migration
  • Fixed 2 occurrences of zero-comparison-to-positive?
  • Fixed 1 occurrence of read-line-any
  • Fixed 1 occurrence of if-let-to-cond
  • Fixed 1 occurrence of when-expression-in-for-loop-to-when-keyword
  • Fixed 1 occurrence of define-lambda-to-define

resyntax-ci bot added 7 commits February 9, 2025 00:14
This expression is equivalent to calling the `positive?` predicate.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
The `define` form supports a shorthand for defining functions.
Use `make-temporary-directory` to make directories instead of `make-temporary-file`.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
Specify a line mode of `'any` with `read-line` to avoid differences between Windows and other platforms.
@rfindler
Copy link
Member

rfindler commented Feb 9, 2025

I don't see any problems.

@sorawee
Copy link
Contributor

sorawee commented Feb 9, 2025

LGTM as well.

@sorawee sorawee merged commit 841c041 into master Feb 9, 2025
3 checks passed
@sorawee sorawee deleted the autofix-80-1 branch February 9, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants